Open dimaip opened 4 years ago
If you are using react-height directly - yeah, it is the case. If as part of react-collapse - then I suggest upgrading react-collapse, latest version does not depend on react-height and react-motion.
@nkbt thanks for the pointer, I'm indeed using older version of react-collapse because of some issues with the newer version. Perhaps I will just re-write this component myself for my project.
Sure, no worries. It’s not that easy though. Look through the source for some ideas.
Cheers, and happy new 2020 from Sydney 🎉
Thanks, I surely will! Happy new year from Moscow!
@nkbt are you open for a small PR to rename this to UNSAFE_componentWillReceiveProps
? I know 18 isn't around the corner just yet, but at least it will get rid of the pesky warning.
Surely
what is the status of this PR? i think React 18 will come soon
Currently this package triggers React's warnings:
At the very least we can rename this method to
UNSAFE_componentWIllReceiveProps
or better yet fix it properly.