search

nkchocoai / ComfyUI-SaveImageWithMetaData

Custom node for ComfyUI. Add a node to save images with metadata (PNGInfo) extracted from the input values of each node.
GNU General Public License v3.0
9 stars 2 forks source link

SD3 Support <3 #22

Open MNeMoNiCuZ opened 3 weeks ago

MNeMoNiCuZ commented 3 weeks ago 
Error occurred when executing SaveImageWithMetaData:

'SD3Tokenizer' object has no attribute 'embedding_identifier'

  File "C:\AI\ComfyUI\execution.py", line 151, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\execution.py", line 81, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\execution.py", line 74, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\custom_nodes\ComfyUI-SaveImageWithMetaData\py\nodes\node.py", line 79, in save_images
    pnginfo_dict_src = self.gen_pnginfo(
                       ^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\custom_nodes\ComfyUI-SaveImageWithMetaData\py\nodes\node.py", line 165, in gen_pnginfo
    inputs = Capture.get_inputs()
             ^^^^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\custom_nodes\ComfyUI-SaveImageWithMetaData\py\capture.py", line 52, in get_inputs
    v = format(v, input_data)
        ^^^^^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\custom_nodes\ComfyUI-SaveImageWithMetaData\py\defs\formatters.py", line 46, in extract_embedding_names
    embedding_names, _ = _extract_embedding_names(text, input_data)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\AI\ComfyUI\custom_nodes\ComfyUI-SaveImageWithMetaData\py\defs\formatters.py", line 81, in _extract_embedding_names
    word.startswith(tokenizer.embedding_identifier)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is the output when running the node with SD3.

nkchocoai commented 3 weeks ago

SD3 is now supported. example workflow is shown below. https://github.com/nkchocoai/ComfyUI-SaveImageWithMetaData/blob/master/examples/sd3.png https://github.com/nkchocoai/ComfyUI-SaveImageWithMetaData/blob/master/examples/sd3.json

MNeMoNiCuZ commented 3 weeks ago

Works great! Thanks.