search

nkdAgility / TfvcBranchPolicy

Enable Branch Policies for TFVC with both TFS and VSTS
Apache License 2.0
8 stars 2 forks source link

Change Branch Lock Policy to look for Tag on Bug Work Items #5

Open MrHinsh opened 8 years ago

MrHinsh commented 8 years ago

During the evaluation of the Branch Lock Policy the bypasspattern is looked for only in the Comment provided. This should be changed to look first to see if this bypasspattern has been added to any of the work items associated with the checkin, and fall back to the Comment if it is not.

hmahajanHM commented 8 years ago

Not clear what to do with these tags identified on Bug WI?

MrHinsh commented 8 years ago

Good point...i have updated the requirement. Also please merge the latest changes before starting...

MrHinsh commented 8 years ago

Do you think that there is more value in iterating through the history than just the Tags (WorkItem.Tags)?

I am concerned about the performance in production...

hmahajanHM commented 8 years ago

The dll Microsoft.TeamFoundation.WorkItemTracking.Client version added in TfvcBranchPolicy.CheckinPolicy project does not support Tags in WI.

Or we can restrict the History comments to recent 5?

MrHinsh commented 8 years ago

I have access to Tags with the 2013 version of the API that we are using: image Can you make sure that you have Visual Studio 2013 Update 5 installed

hmahajanHM commented 8 years ago

Ok let me check at my end again

hmahajanHM commented 8 years ago

This week I will be able to spend approx. 5-6 hours on this tool.

MrHinsh commented 8 years ago

That sounds awesome... :) did you see that I commented on the code for https://github.com/hmahajanHM/TfvcBranchPolicy/commit/0beb59d20d32d36e8a2dc394a6b50cbca9c5867e

hmahajanHM commented 8 years ago

yes, was not sure how tags treet ; so thought better to rely on TFS for and break tags separate and then check each one.

MrHinsh commented 8 years ago

How did you get on with this?