search

nkdAgility / azure-devops-migration-tools

Azure DevOps Migration Tools allow you to migrate Teams, Backlogs, Tasks, Test Cases, and Plans & Suits from one Project to another in Azure DevOps / TFS both within the same Organisation, and between Organisations.
https://nkdagility.com/learn/azure-devops-migration-tools/
MIT License
493 stars 328 forks source link

Fix for TfsAttachmentEnricher not properly setting the workItemServer #2006

Closed jacobmalliet closed 6 months ago

jacobmalliet commented 6 months ago

Resolves an issue with the TfsAttachmentEnricher where _server instance was always null. This seemingly occurred because of a duplicate WorkItemServer instance variable _workItemServer.

After attempting to use workItemServer instead, I found that it was also not being set properly because of a null comparison being done incorrectly.

This change removes the duplicate WorkItemServer variable and properly initializes the _workItemServer before exporting attachments.

First time contributing so let me know if you need anything else changed here.

MrHinsh commented 6 months ago

I made that change.

MrHinsh commented 6 months ago

Replaced by https://github.com/nkdAgility/azure-devops-migration-tools/pull/2008

jacobmalliet commented 6 months ago

I made that change.

Thank you!

MrHinsh commented 6 months ago

I had to recreate the PR and its all merged into Preview