search

nkfoss / Ohm-str-react

The React ported and improved version of Ohm Strength
0 stars 0 forks source link

Create a navbar to accompany the sidedrawer #3

Open nkfoss opened 3 years ago

nkfoss commented 3 years ago

Sidedrawer will be moved out of Navbar, because they are now two seperate entities

These two might have to go into their own component together. Maybe a higher-order component like Layout.

Navbar will start showing at a minimum width, and sidedrawer stops showing at a maximum.

They will receive the same options for navigation.

michael-small commented 3 years ago

I personally find Layout to be a bit ambiguous. Would it encompass more than the navbar and sidedrawer? Like the content of a full page, almost like our App right now?

My intention with Navbar I think was like your idea of conditional width query for the drawer or bar. That would be calculated and executed in Navbar. Perhaps rename it to a broader term like Navigation. Then Navigation is embedded in App like Navbar is now. Or like the way I interpret your proposal, Navigation as one child of Layout.

nkfoss commented 3 years ago

My thought is that a larger container for both the navbar/sidedrawer, and probably not anything else. The 'navigation' container would conditionally render either the navbar or drawer, and would contain all logic for that.

Just my first thoughts, open to your idea as well