search

nkfoss / ohm-str

0 stars 0 forks source link

FetchRecords() is called at inappropriate time #43

Closed nkfoss closed 4 years ago

nkfoss commented 4 years ago

When going from EditExerciseComp -> SetListComp, fetchRecords gets called. This is not necessary, because the RepMaxService is never destroyed during any transition between SLC and EEC... furthermore, the records can never be modified during this process, so we can assume the local records don't need to be updated from the database.

nkfoss commented 4 years ago

It appears that fetchRecords is NOT actually fetching records when called at inappropriate times. There was a built-in check that prevented unneccessary database requests. This check was moved out of the service and into the component that calls the service.