Improvement and Code refactoring - Githubissues

nkg114mc / c-gomoku-cli

Command Line Interface tool for Gomocup gomoku/renju engines

GNU General Public License v3.0

7 stars 3 forks source link

Improvement and Code refactoring #5

Closed dhbloo closed 3 years ago

dhbloo commented 3 years ago

Hi Chao,

This PR contains serveral stability improvement and massive code refactoring that I have done in the past few days:

Stability Improvement

Better API error report on Windows
Use a global job to associate all subprocesses, reducing OS resource usage
Survive (rare) engine crashes and hard timeouts after tolerance by default. Match result will be marked as crash loss or timeout loss in such case. Original behaviour can be switched back using option -fatalerror.
More natural (thread-safe) result output to stdout and error output to stderr

Bug Fixes

Fix handle inheritance on Windows
Fix game sample saving
Fix tolerence option in each

Code Refactoring

Completely remove str.h and vec.h with replacement of std::string and std::vector
Completely remove pthread.h with replacement of std::thread and std::mutex
Class methods are renamed, and classes are refactored to satisfy C++ common idiom (eg. use Constructor/Destructor instead of init()/destroy())
Added clang-format
Tweak compile flags for better binary size

nkg114mc commented 3 years ago

Thanks, Haobin! You are so productive :)