cleaned up all request bodies

nkgilley / python-ecobee-api

Python API for controlling Ecobee Thermostats

MIT License

44 stars 40 forks source link

cleaned up all request bodies #31

Closed uchagani closed 6 years ago

uchagani commented 6 years ago

@nkgilley All requests bodies have been refactored. I added the json.dumps call to the make_request method.

I've tested all of the functionality except for 2:

delete_vacation: I couldn't figure out how to set a name for a vacation and thus couldn't delete it to ensure this method works
set_humidity: I only have an ecobee 3 lite and you can't set humidity levels in that version.

uchagani commented 6 years ago

@nkgilley Can we get a new pypi release please?

nkgilley commented 6 years ago

@uchagani I posted a new release yesterday: https://pypi.org/project/python-ecobee-api/0.0.16/ On Mon, Feb 19, 2018, 10:15 AM uchagani notifications@github.com wrote:

@nkgilley https://github.com/nkgilley Can we get a new pypi release please?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nkgilley/python-ecobee-api/pull/31#issuecomment-366722278, or mute the thread https://github.com/notifications/unsubscribe-auth/ABcAqoeGq39pmjVH3GwTw_TaXAs-ivZXks5tWY_-gaJpZM4SJJp7 .

uchagani commented 6 years ago

awesome. Sorry didn't see a release here on github so figured it wasn't done.