search

nkgilley / python-ecobee-api

Python API for controlling Ecobee Thermostats
MIT License
44 stars 40 forks source link

Refactoring needed to support Home Assistant config flow #40

Closed marthoc closed 5 years ago

marthoc commented 5 years ago

Hi @nkgilley, I've been looking at adding a config flow for ecobee to Home Assistant. That means that some refactoring would be needed here since I need to wrap the sync calls used in this library with hass's async wrapper for use in the config flow, and I'm trying to avoid stray sync calls in this library (e.g. init for the Ecobee class calls both request_pin() and update()). Would you be open to some PRs? In the future it could also be worth updating this to async for use in hass and I could spearhead that too if you're open to it.

nkgilley commented 5 years ago

Yes, I'm definitely open to that 🙂 Looking forward to your PRs

On Tue, Sep 10, 2019, 6:19 PM Mark Coombes notifications@github.com wrote:

Hi @nkgilley https://github.com/nkgilley, I've been looking at adding a config flow for ecobee to Home Assistant. That means that some refactoring would be needed here since I need to wrap the sync calls used in this library with hass's async wrapper for use in the config flow, and I'm trying to avoid stray sync calls in this library (e.g. init for the Ecobee class calls both request_pin() and update()). Would you be open to some PRs? In the future it could also be worth updating this to async for use in hass and I could spearhead that too if you're open to it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nkgilley/python-ecobee-api/issues/40?email_source=notifications&email_token=AALQBKV4UNHQSVTHR5WS3GTQJAMP5A5CNFSM4IVNFII2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKSGIKA, or mute the thread https://github.com/notifications/unsubscribe-auth/AALQBKTIV4BB266TKCJHLDDQJAMP5ANCNFSM4IVNFIIQ .

marthoc commented 5 years ago

Awesome. I'll make some changes locally and get the config flow working - once that's done, I'll open a PR and we can maybe do more testing before you cut a new version of pyecobee.