Updates to set_fan_mode/set_climate_hold

nkgilley / python-ecobee-api

Python API for controlling Ecobee Thermostats

MIT License

44 stars 40 forks source link

Closed bjpetit closed 3 years ago

bjpetit commented 3 years ago

set_fan_hold

Make optional parameters (holdHours, coolHoldTemp, heatHoldTemp)
- holdHours must be set if holdType is set to holdHours.
- coolHoldTemp and heatHoldTemp are optional. Setting these values in set_fan_hold can lead to unexpected behavior This behavior has an issue in the HA repo (home-assistant/core#40087) set_climate_hold
Fix comparison which was throwing a python warning.

bjpetit commented 3 years ago

I triggered closing of #64. So I'm carrying this forward here, based on the conversation in the prior PR. The key updates here are...

Made optional parameters using kwargs for holdHours, coolHoldTemp and heatHoldTemp
I've verified that the Ecobee API accepts this request with or without the HoldTemp parameters