nkgilley / python-ecobee-api

Python API for controlling Ecobee Thermostats
MIT License
44 stars 40 forks source link

Add support for ecobee smart sensors for doors and windows #68

Open Maharshi-Pathak opened 3 years ago

Maharshi-Pathak commented 3 years ago

Hi I would like to contribute to this repo and collaborate with you to introduce the capability to add the door and window smartsensors into Ecobee integration directly. Since, these are only occupancy (remote) sensors and not thermostats, currently the ecobee integration does not recognize them as binary sensors. In my understanding this is due to the way the ecobee API calls are made in the get_remote_sensors() function i.e. self.thermostats[index]["remoteSensors"]. Please let me know if this something you have on your to do list already or you'd like to discuss more on this to get the ball rolling on this.

nkgilley commented 3 years ago

I have no plans to add it, but I would welcome a PR. Thanks

On Mon, Jun 14, 2021 at 2:42 PM Maharshi-Pathak @.***> wrote:

Hi I would like to contribute to this repo and collaborate with you to introduce the capability to add the door and window smartsensors into Ecobee integration directly. Since, these are only occupancy (remote) sensors and not thermostats, currently the ecobee integration does not recognize them as binary sensors. In my understanding this is due to the way the ecobee API calls are made in the get_remote_sensors() function i.e. .get(ecobee.thermostats). Please let me know if this something you have on your to do list already or you'd like to discuss more on this to get the ball rolling on this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nkgilley/python-ecobee-api/issues/68, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALQBKW7KCFWENCECSRBHBDTSZESDANCNFSM46VYPDPQ .