search

nkgilley / sbrscrape

Python scripts for scraping odds data from sbrodds (sportsbookreview)
MIT License
13 stars 3 forks source link

Incorrect Totals #4

Open jnish23 opened 7 months ago

jnish23 commented 7 months ago

I've noticed this for a few days. It appears that the totals for NBA (haven't checked other sports) get mixed up for a couple games.

For example today (2023-11-15) it lists the total for Milwaulkee @ Toronto at 229 when its 224.5 (Mixes it up with NYK @ Atlanta). And Sacramento @ Lakers it says 217.5 instead of 235.5. (Mixes it up with the Cleveland @ Portland game. See the pictures for reference. Something is getting mixed up.

image

image

nkgilley commented 7 months ago

if you see this again, can you please provide output from sbrodds, and the source code of the sbrodds page? thanks!

something like this:

import json
from sbrscrape import Scoreboard
games = Scoreboard(sport="NBA").games
print(json.dumps(games, indent=2))
magic8bull commented 7 months ago

also put this on the NBA-Machine-Learning-Sports-Betting issues, believe this is the same issue as #328 and #360 there.

I "think" the issue is related to the sbrscrape making multiple calls to SBR and assuming the results are returned in the same order for the ML, Odds, etc. But they aren't. Even if you review the webpage they sometimes come back in a different order. Could be wrong but it seems the issue is with the scrape, not upstream.

nkgilley commented 7 months ago

I was able to reproduce this today. I'll have to take a closer look when I have time. PRs welcome!!

nkgilley commented 7 months ago

should be fixed in 0.0.10