nkh / P5-App-Asciio

Plain ASCII diagram
https://nkh.github.io/P5-App-Asciio/
51 stars 4 forks source link

Drag-drop functionality #159

Closed nkh closed 7 months ago

nkh commented 7 months ago

See #155 for complete stencil picker requirements

Implement drag-drop for:

nkh commented 7 months ago

Branch containing dnd sink.

https://github.com/nkh/P5-App-Asciio/tree/dnd

qindapao commented 7 months ago

@nkh How should I operate this function?

I don't have a new window to pop up in cygwin environment.Maybe I'll go home and try it on wsl linux.

If it's convenient, can you record a small video.

nkh commented 7 months ago

@qindapao this is a work in progress, only drop works and does nothing.

I'll ping you when it's done.

qindapao commented 7 months ago

@nkh ok

I'm still in the company, having a boring meeting.The company's computer only have cygwin execution environment.But I have cygwin and wsl linux execution environments at home.

nkh commented 7 months ago

@qindapao I've gotten a bit further but it's not ready yet for prime time.

dnd_test

qindapao commented 7 months ago

@nkh It looks wonderful.I'll have a look tomorrow or the day after tomorrow.I'm busy with pen mode recently, and I'm thinking about customizing a cursor.It's 50% done.

nkh commented 7 months ago

@qindapao if we getthe UX right we can use drag-and-drop to get elements from a stencil.

nkh commented 7 months ago

@qindapao this is the state of Drag and Drop, I'm going to integrate it into main

if you're ready with polygon selection within one or two hours, I'll integrate it after, otherwise you'll have to rebase.

to make Drag and Drop work I had to rebind "C00-button-press-1" and introduce a few more bindings, I don't think it has an impact on your bindings.

dnd_test

qindapao commented 7 months ago

@nkh You deal with it first. I'm outside with my family.

nkh commented 7 months ago

merged in 372a350

@qindapao can you please delete the remote branches you don't need? the command is:

git push origin --delete name_of_the_branch

I track both your github repo and mine to do tests and merging. As you can see below I have 4 branches and you have 12; most of your branches are already merged, they only take place in the display when I look at the log.

1357 T ~/.../P5-App-Asciio main 1⇡ 26ᵤ gba
ª1ᵇ0     *main                                 5 minutes ago  372a35  ADDED: Drag and Drop
ª0ᵇ0     origin/main                           23 hours ago   bfe065  CHANGED: binding to enter selection mode
ª0ᵇ1     qindapao/fix_markup_cross             24 hours ago   31cd4b  FIXED: markup characters need to be deleted
ª0ᵇ2     qindapao/main                         33 hours ago   6bb565  CHANGED: always run web server
ª15ᵇ314  origin/gh-pages                       3 days ago     4cfece  deploy: c498d616de2b1aabab95d5308f41570fe455a1ae
ª2ᵇ11    qindapao/element_trans                6 days ago     a2e3c7  ADDED: anything becomes a big text
ª0ᵇ13    qindapao/fix_mouse_shape              7 days ago     74b1c1  FIXED: The mouse shape is abnormal after the clone mode ends
ª1ᵇ14    qindapao/mouse_polygon_selc_rebase    7 days ago     5ea262  ADDED: mouse polygon selection
ª1ᵇ16    qindapao/mouse_polygon_selec          7 days ago     428a20  ADDED: mouse polygon selection
ª0ᵇ15    qindapao/cross                        7 days ago     d426f9  ADDED: integrate cross mode through zbuffer
ª2ᵇ17    qindapao/cross_integration            7 days ago     599958  FIXED: the original zbuffer object cannot be changed in the cross module
ª2ᵇ27    qindapao/multi_asciio_share_elements  13 days ago    82a7f2  FIXED: Adjust receiving and sending clipboards.
ª1ᵇ36    qindapao/cross_zbuffer                3 weeks ago    69b883  CHANGED: cross mode use zbuffer
ª0ᵇ39    1.9.02                                4 weeks ago    7865d1  CHANGED: installation documentation
ª0ᵇ40    1.9.01                                4 weeks ago    b4e006  ADDED: mouse support in tasciio
ª2ᵇ47    disable_arrow_connector               5 weeks ago    f1a526  ADDED: disable start connector dis-connection
ª2ᵇ47    origin/disable_arrow_connector        5 weeks ago    f1a526  ADDED: disable start connector dis-connection
ª1ᵇ54    astar_direction                       6 weeks ago    b53d76  ADDED: directional cost
ª1ᵇ59    qindapao/complete_cross               8 weeks ago    f1e3e7  ADDED: Finish all characters of cross mode
ª1ᵇ314   qindapao/gh-pages                     3 months ago   119acb  deploy: 498674707716f178b47624701fdd1da830bc214d
qindapao commented 7 months ago

@nkh There should be something wrong. Look at the website. I should only keep four branches.

qindapao commented 7 months ago

@nkh

Screenshot_20231202_205823

qindapao commented 7 months ago

@nkh Many of the branches you showed there have been deleted by me.

nkh commented 7 months ago

@qindapao good job deleting them last time, I made the error to keep them instead for pruning them.