replace code-box with more generic type

[nkh]

@qindapao you have implemented the code-box but I think these points could be better

• it has a separate input dialog
• the contents are not regenerated
• it's very specific

we already have 2 types of command boxes

• one that executes a command and fills the box, the command is lost
• one that executes a command and keeps it but each line is a command so giving it multiline input is not possible

I have implemented in a933d8adea6280cfea6ba041e801471f2967eed4 a new type of command box, one that takes command verbatim. try it and let me know if you think it's a good replacement for the code box (how often do you use it?)

I had to change the implementation of the exec box a bit because the old version would run each line as a separate command, the new one takes the command verbatim.

it also can take a start command, here is how they are added to the stencils

create_element
    (
    NAME => 'Boxes/exec verbatim',
    CLASS => 'App::Asciio::stripes::exec_box',
    TEXT_ONLY => '$',
    EDITABLE => 1,
    NO_BORDER => 1,
    RUN_VERBATIM => 1,
    ) ,

create_element
    (
    NAME => 'Boxes/exec add lines',
    CLASS => 'App::Asciio::stripes::exec_box',
    TEXT_ONLY => '$',
    EDITABLE => 1,
    NO_BORDER => 1,
    RUN_VERBATIM => 1,
    VERBATIM_COMMAND => "nl -n ln -w 2 -s' ' 2>&1 "
    ) ,

We still have the possibility for a user input that looks like the code-box but I'd rather have it use the above mechanism for execution.

[qindapao]

@nkh

I have tried your revised version, and the effect is very good. It support editing it again.Use your implementation

The command box really creates an infinite number of possibilities

[qindapao]

Please help update the document, and must tell the user the details.

For an example of a command box combined with an external tool, we may need to document it as a topic to help users use it better.

I think this part already belongs to the advanced usage of asciio, and it is extremely efficient to use it well

[qindapao]

exec add lines There is a small bug that needs to be fixed

When the user does not have any input directly click OK, the program will hang

[nkh]

Good catch but that's not a bug, if the command requires input it will wait for it; it's a user error.

But your point is valid, I've added a timeout for all commands, it's set to 2 seconds for now, running the code that adds line will now fail and display this message.

              Can't execute 'nl -n ln -w 2 -s' ' 2>&1 ':
              output:                                   

              error:                                    
               [31744]                                  

[nkh]

I also have added #44 to make the dialogs more usable

[nkh]

@qindapao I just committed 65bcb73, the exec boxes are refactored, use a larger dialog, and there's some documentation in mdbook.../stencils/asciio_exec_box.

[nkh]

@qindapao

please check this work, I've added these four stencils so they can be reached via the popup

'Asciio/Boxes/exec' 'Asciio/Boxes/exec verbatim' 'Asciio/Boxes/exec verbatim once' 'Asciio/Boxes/exec add lines'

the documentation is in stencils/asciio_exec_box

the simplest way to use them is via the bindings I have also added

• «ie» 'Asciio/Boxes/exec'
• «iv» 'Asciio/Boxes/exec verbatim'
• «io» 'Asciio/Boxes/exec verbatim once'
• «i +ctll» 'Asciio/Boxes/exec add lines', ctl-l was your old binding, I'd like to remove the ctl part

if all is good for you we can close this ticket

[qindapao]

@nkh

It is much more valuable than my implementation, I like it very much, please close issuee.