search

nkh / P5-App-Asciio

Plain ASCII diagram
https://nkh.github.io/P5-App-Asciio/
54 stars 4 forks source link

Cross mode error #51

Closed nkh closed 1 year ago

nkh commented 1 year ago

@qindapao

I started testing the cross mode and I like it!

I found an error, you're not the only one good at it ;)

cross_bug

here's the asciio file

cross.asciio.gz

Please post, in this thread, the asciio files you're using in the small videos you made.

nkh commented 1 year ago

Where's the normal_filler_background color used?

nkh commented 1 year ago

Another one

cross_bug2

I use these colors

cross_element_backgroud => [1, 1, 1],
cross_filler_background => [1, 0.9, 0.9],
normal_filler_background => [0, 1, 0],
qindapao commented 1 year ago

@qindapao

I started testing the cross mode and I like it!

I found an error, you're not the only one good at it ;)

cross_bug

here's the asciio file

cross.asciio.gz

Please post, in this thread, the asciio files you're using in the small videos you made.

demo.zip

Are you saying the problem is the arrow is missing? But the cross mode does not cause the element to disappear.let me run your graph and see

qindapao commented 1 year ago

https://github.com/nkh/P5-App-Asciio/issues/51#issuecomment-1615111473

cross_mode_front_and_back

For this problem, it is related to the front and back of the element. If the box is in the background, then the arrow crosses it to generate the plus sign. Otherwise some characters are obscured and no plus sign will be generated.

The user can get the desired result by adjusting the front and back. I think it's best not to destroy the front-back relationship of elements.

In addition, I am also quite entangled in the choice of cross fillers in ascii mode (unicode is simple and unambiguous). Is it appropriate to use plus signs or dots and backticks when three sides intersect? What is your opinion?

For the dots and backticks that intersect on three sides, I refer to the rules of existing elements so as not to damage the style.

qindapao commented 1 year ago

image

In this case, I didn't set the fillers because if there were only dots and backticks vertically, the box would look weird.

qindapao commented 1 year ago

image

You see here, only the plus sign takes into account the possibility of dots and backticks appearing up, down, left, and right.

qindapao commented 1 year ago

https://github.com/nkh/P5-App-Asciio/issues/51#issuecomment-1615389264 arrow_disappear

I did an experiment with your asciio file, and found that the disappearance of the arrows should have nothing to do with the cross mode, and it should be a problem elsewhere.

qindapao commented 1 year ago

Where's the normal_filler_background color used?

If ordinary fillers are converted into cross fillers, they can be correctly retained and deleted, and these elements need to be different from normal elements.

Their special identities need to be identified to tell users that they are not real elements.

nkh commented 1 year ago

disappearing arrow

Ah, I see now why the arrow disappears! Well it doesn't!

I think it's re-routed on top of the other one. this is a good example and I will use it in the documentation

small box not crossed

I think you made a good choice not showing the crossing when the result would look weird with a row of dots, maybe a '+' sign would be good, as in your example, let me think about it a bit longer, in the worst case we can have it an option.

ASCII is limited and that's why I like it :)

fillers

I still don't get it, please make me a video when you have time

qindapao commented 1 year ago

I noticed a detail when you said that. The arrow flashed and then disappeared, like the arrow attached below arrow,Use debug to find that it is still there?.

normal fillers and color.

In fact, simply speaking, it is to distinguish it from the user's own elements. So that they don't have to manipulate these elements.Even after they enter the normal mode, the user's misoperation leads to the the position of the fillers is disordered.Then it is convenient to identify them, select them, and then delete them.

What do you think of this explanation?

If you still don't understand or feel a little redundant.When I have time, I will make a video to show you clearly why we need ordinary filler and give it a color.It's a pity that I was in the company this afternoon.But my spoken English is very poor.I guess I can only do silent video,The English I speak is Chinglish:)

qindapao commented 1 year ago

Do you think giving it a color will make the normal elements after the cross elements are converted look weird?

It seems really reasonable. Let me see if there is a problem if we don't give them color.It doesn't seem to be a big problem, after all, it will be deleted automatically after entering cross mode. As long as users don't sabotage(For example, the normal fillers are deliberately placed in various positions of the diagram, which can only be found through global selection), it's not a big problem.

nkh commented 1 year ago

I will wait for a video :) text on the vide will be fine. Being able to make videos, even without voice, is a good skill when documenting and documenting is part of development.

I'm not expecting anyone to speak the language I speak, I'm willing to make efforts so we understand each other, even with small scribbles on a napkin if necessary.

A fun story: I was in Singapore and needed to buy a book (when that was still a thing), I called the bookshop and asked a question, I understood nothing to the answer so I said "Sorry but I don't speak Chineses" and got a slow spoken answer ... "I am speaking English!", Singrish was more like it ;)