Closed nkh closed 1 year ago
@nkh
Leave it to me. I think I know what the problem is.You can do something else.
But I can't do it today. It's Saturday.
@nkh
use List::Util qw(first) ; use List::MoreUtils qw(any);
These two sentences should be added to cross.pm
You let me know when you have a commit that works, I'm working on a ticket from 2016, lol!
@nkh
It was modified based on yours, I did not use the new commit.
@nkh
I used the following command
git commit --amend
@qindapao, works fine, good job.
It's better to not amend commits in an branch where two or more do work, it makes impossible to see the steps. The one merging can squash instead.
What do you think about having the line crossing mode, I think that's a better name, integrated?
To make it easier to use this mode, it would be nice if you could fix #72, let me know if it is not clear.
@nkh
Ok, I see, I can use that command in one person's development branch, but it is not suitable for multi-person development branch.
I will modify the name in the next commit.
I have merged into master, I recommend you throw away all your branches that are related to this work (I've just done that), and start anew from master for changes
Integration branch: https://github.com/nkh/P5-App-Asciio/tree/integrate_cross_mode
I have added some debugging output which displays this title "Get crossing mode overlay:" and then the overlay characters. This is the code:
and this is the error: