search

nkh / P5-App-Asciio

Plain ASCII diagram
https://nkh.github.io/P5-App-Asciio/
53 stars 4 forks source link

Add border connection for ellipse and rhombus #96

Closed qindapao closed 1 year ago

qindapao commented 1 year ago

@nkh

Found out today that the two shapes are missing this.I have added and removed some redundant code, please check

https://github.com/qindapao/P5-App-Asciio/commit/08d65393077297cdaaab54adef021ea3386383d3

nkh commented 1 year ago

The patch shows that you have removed the code I've just added, I don't see how make_elements ASCII or Unicode is related to border connection and why it's removed.

nkh commented 1 year ago

why are you removing this?

screenshot_2023-07-11_16-11-05

qindapao commented 1 year ago

@nkh

You are mistaken. I removed the old function before, and the code you added has not been removed.

qindapao commented 1 year ago

@nkh

Yours is this function.

make_selection_unicode

nkh commented 1 year ago

Indeed, I completely forgot about make_ascii (from february this year) . Good that out found out that it wasn't used any more.

nkh commented 1 year ago

@qindapao merged

nkh commented 1 year ago

@qindapao Did you've seen, in make_selection_unicode, that I have left place holders for other shapes, I don't know if they have unicode character set too.

qindapao commented 1 year ago

@nkh

I saw your note.It doesn't matter. At present, there is only one rhombus with a weird unicode slash. I even want to cancel it.

At present, only unicode of regular boxes looks better.

qindapao commented 1 year ago

Unicode slashes don't look so beautiful.

nkh commented 1 year ago

I disagree, the triangle looks good and the other shapes are useful, specially the ellipse.

Only the triangle renders well in SVG but it's because you made the effort to make it look good in ASCII. If we want something that looks OK in ASCII and good in SVG we should follow this. https://github.com/blampe/goat or this https://ivanceras.github.io/content/Svgbob/Circles.html, https://ivanceras.github.io/content/Svgbob/Specification.html

You can see in the circle specification that it doesn't look as good as yours in ASCII and it doesn't scale.

screenshot_2023-07-11_16-43-52

qindapao commented 1 year ago

@nkh

I like ellipse, which cost me a lot of effort.

It's just not easy to find suitable unicode characters.

It looks better in ascii.I still don't like using svg. Our ellipse is better.We don't have to sacrifice our standards to meet other software.As for the cooperation with them, we can get a special shape to meet their interfaces in the future.But I don't think these priorities are high.

qindapao commented 1 year ago

@nkh

You may have misunderstood, but I definitely like other shapes.I wrote the rhombus. How could I not like it?It's just that unicode slashes look a little unnatural.

It's just that other shapes are not easy to find suitable unicode characters.But it doesn't matter.

My English expression is sometimes misleading. After all, I don't live in an English environment. Please forgive me.

qindapao commented 1 year ago

There is a unicode slash in the right-click menu of the rhombus, which is a double-width unicode character. Just look at it. If you also don't think it looks good, we can cancel this type.So the rhombus has no unicode type.