search

nkhorman / archive-growl

Automatically exported from code.google.com/p/growl
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Growl target in Growl-1.1.4 won't build unless GrowlHelperApp already exists (osacompile fails) #94

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I discovered (by accident, while working on hooking up the Growl project file 
to Camino's project 
file) that the Growl target in Growl 1.1.4 won't build on a machine without an 
existing Growl 
install.

Specifically, the Growl target is trying to build GrowlHelperApp, which depends 
on the 
GrowlAction project, whose AppleScript depends on...GrowlHelperApp (or rather 
the compiled 
app's scripting dictionary). If you don't have Growl installed, the build fails:

Building target “GrowlAction” of project “GrowlAction” with 
configuration “Development” — (1 
error)
     mkdir "/Users/smokey/Desktop/Downloads/Growl-1.1.4-
src/Extras/GrowlAction/build/Development/Show Growl 
Notification.action/Contents/Resources/Scripts"
    cd "/Users/smokey/Desktop/Downloads/Growl-1.1.4-src/Extras/GrowlAction"
    /usr/bin/osacompile -d -i /System/Library/Frameworks/AppleScriptKit.framework -l 
AppleScript -U main.applescript -o "/Users/smokey/Desktop/Downloads/Growl-1.1.4-
src/Extras/GrowlAction/build/Development/Show Growl 
Notification.action/Contents/Resources/Scripts/main.scpt" 
"/Users/smokey/Desktop/Downloads/Growl-1.1.4-src/Extras/GrowlAction/main.applesc
ript"
/Users/smokey/Desktop/Downloads/Growl-1.1.4-src/Extras/GrowlAction/main.applescr
ipt:11: 
Expected end of line but found “"”. (-2741)
  /Users/smokey/Desktop/Downloads/Growl-1.1.4-
src/Extras/GrowlAction/main.applescript:11: Expected end of line but found 
“"”. (-2741)
  /Users/smokey/Desktop/Downloads/Growl-1.1.4-
src/Extras/GrowlAction/main.applescript:11: Expected end of line but found 
“"”. (-2741)
Build failed (1 error)

Before I realized I didn't need to build the Growl target to produce what I 
needed to add to the 
Camino project, I fixed the dependencies to build GrowlHelperApp, then build 
GrowlAction, and 
then have an aggregate target put the Automator action inside GrowlHelperApp; 
Growl then 
depends on the aggregate target instead of on GrowlHelperApp individually.

I don't know if this patch applies to what's in the source repo, or if you're 
concerned with 
building on clean (Growl-less) systems, etc., but since I hadn't tossed out the 
patch I made to fix 
the dependencies, you're welcome to it ;-)

Original issue reported on code.google.com by chrisf.g...@gmail.com on 6 Dec 2009 at 2:22

GoogleCodeExporter commented 9 years ago 
Here's the diff from the person who filed it.

Original comment by chrisf.g...@gmail.com on 6 Dec 2009 at 2:23

Attachments:

GoogleCodeExporter commented 9 years ago 
You guys might have fixed this by 1.2; I didn't pay close attention when I was 
upgrading us to the 1.2 
framework (and built only the framework this time), but it looked like the 
dependencies for GHA and the 
Action had changed.  At the very least the project changes probably will make 
the patch fail to apply ;-)

Original comment by smokey.ardisson@gmail.com on 6 Dec 2009 at 6:54

GoogleCodeExporter commented 9 years ago 
I just built in debug build while gha was not running. Did this not work with 
it not running, or not installed?

Original comment by chrisf.g...@gmail.com on 6 Dec 2009 at 7:09

GoogleCodeExporter commented 9 years ago 
Not installed: "the Growl target in Growl 1.1.4 won't build on a machine 
without an existing Growl 
install."

Original comment by smokey.ardisson@gmail.com on 6 Dec 2009 at 7:20

GoogleCodeExporter commented 9 years ago 
I stopped GHA and GrowlMenu and then uninstalled the prefpane. Cleaned the 
project and built the Growl target 
in debug.

Working on a Release build, but codesigning is not my friend.

Original comment by chrisf.g...@gmail.com on 6 Dec 2009 at 7:53

GoogleCodeExporter commented 9 years ago 
Just built in release without Growl being installed. Checked by having Adium 
launch and it prompted to install 
Growl. 

No longer an issue. Closing.

Original comment by chrisf.g...@gmail.com on 6 Dec 2009 at 9:31