Closed theory closed 10 years ago
Currently this foreign data wrapper works only with PostgreSQL 9.2 (no support for 9.3 yet), and also it depends on libyajl. Does this have implications on its suitability for PGXN?
No, just document the prereqs in the README, ideally with a link to download. You can see that the META.json
file already specifies that 9.2 is required. If you wanted to release it before 9.3 is supported, you can change that bit to:
"prereqs": {
"runtime": {
"requires": {
"PostgreSQL": ">= 9.2.0, < 9.3.0"
}
}
},
See twitter_fdw, which requires some C libs, for how it mentions stuff in its README.
You already have everything you need in the README. Duh. Sorry for the noise.
Hello David,
Sorry for the delay. We'll test the changes for OS X and 9.3 compatibility some time this week, then will add the extension to the PGXN.
Thanks, -- Hadi
@pykello++
I added 9.3 support and OS X support after testing in different platforms, and also added the META.json for PGXN. I requested a PGXN account to submit the extension. Can you please test the extension once more in case I've missed something?
Looks good, all tests pass on 9.3. \o/
Only thing I notice is that PGXN is pickier about license keys than I thought, thinks yours is invalid. This patch fixes it:
--- a/META.json
+++ b/META.json
@@ -4,7 +4,7 @@
"description": "PostgreSQL extension which implements a Foreign Data Wrapper (FDW) for JSON files.",
"version": "1.0.0",
"maintainer": "Hadi Moshayedi <hadi@citusdata.com>",
- "license": "gpl_3_0",
+ "license": "gpl_3",
"provides": {
"json_fdw": {
"abstract": "Foreign Data Wrapper for JSON files",
json_fdw is in PGXN now \o/
Looks good, thanks!
PGXN is an extension distribution network for PostgreSQL. Distributing your extension on PGXN is pretty straight-forward; the only thin it needs is an account and a
META.json
file. Here is the file. You can get the details on creating an account and uploading distributions in the PGXN HOWTO.