Add Dynamic API Data on Index Page

nkilm / riddles-api

An API which returns a riddle each time a call is made.

https://riddles-api.vercel.app

MIT License

23 stars 8 forks source link

Add Dynamic API Data on Index Page #2

Closed SarojWasti closed 2 years ago

SarojWasti commented 2 years ago

I updated the code to display api response dynamically on index page as well as fixed rendering issues with longer riddles which would break out of div and make web page a mess.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
riddles-api	✅ Ready (Inspect)	Visit Preview	Oct 8, 2022 at 8:58AM (UTC)

nkilm commented 2 years ago

previous css path link was correct. we don't prepend /public while accessing the files inside /public, it will be handled by expressjs. Your code removes all CSS, check here - https://riddles-869v0m4sj-nkilm.vercel.app/
NOTE: All commits are to be squashed to single commit bearing meaningful message(adding description is optional, but recommended)

How do I squash my last N commits together?

PR will not be accepted if not squashed.

nkilm commented 2 years ago

nkilm / riddles-api

Add Dynamic API Data on Index Page #2

previous `css` path link was correct. we don't prepend `/public` while accessing the files inside `/public`, it will be handled by expressjs. Your code removes all CSS, check here - https://riddles-869v0m4sj-nkilm.vercel.app/

NOTE: All commits are to be `squashed` to single commit bearing meaningful message(adding description is optional, but recommended)

Also some riddles are very long. So display only those riddles which are short (maximum of 10-15 words).

nkilm / riddles-api

Add Dynamic API Data on Index Page #2

previous css path link was correct. we don't prepend /public while accessing the files inside /public, it will be handled by expressjs. Your code removes all CSS, check here - https://riddles-869v0m4sj-nkilm.vercel.app/

NOTE: All commits are to be squashed to single commit bearing meaningful message(adding description is optional, but recommended)

Also some riddles are very long. So display only those riddles which are short (maximum of 10-15 words).

previous `css` path link was correct. we don't prepend `/public` while accessing the files inside `/public`, it will be handled by expressjs. Your code removes all CSS, check here - https://riddles-869v0m4sj-nkilm.vercel.app/

NOTE: All commits are to be `squashed` to single commit bearing meaningful message(adding description is optional, but recommended)