search

nkinney06 / youtube-to-fen

add FEN annotations to chess videos on youtube
1 stars 1 forks source link

Invalid FENs even when no chessboard in the video frame #1

Open mcaap opened 1 year ago

mcaap commented 1 year ago

Hi,

Thanks for the repo! Trying with your default video. I noticed that even when there is no chessboard in the video frame, it throws out some invalid FENs. Is this expected?

Screenshot 2023-08-31 at 7 21 26 PM

Cheers!

nkinney06 commented 1 year ago

That's expected. Back when I was working on this it didnt matter if I had a few bogus FEN strings at the beginning and end. I was basically taking pgn files (for which every FEN is valid) and looking up those FENs in the video files: so the invalid FENs didnt matter. That said, since posting this code I've decided to revisit the project and clean up this script. It's rather sloppy in some ways. Right now I'm trying to eliminate some of the intermediate file I\O and clean up the code (this was an early python project for me). I'm struggling a bit with the numpy and PImage data types but once I work it out I should be able to address the issue you mention. Thanks for checking in out the repo!

On Thu, Aug 31, 2023 at 9:52 AM mcaap @.***> wrote:

Hi,

Thanks for the repo! Trying with your default video. I noticed that even when there is no chessboard in the video frame, it throws out some invalid FENs. Is this expected?

[image: Screenshot 2023-08-31 at 7 21 26 PM] https://user-images.githubusercontent.com/3183663/264666532-d76a6e38-fa51-4b2d-8b82-7656ad56b7f4.png

Cheers!

— Reply to this email directly, view it on GitHub https://github.com/nkinney06/youtube-to-fen/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJPREGLHMS4KQT5YQKIQ3VDXYCJKBANCNFSM6AAAAAA4GDXTQY . You are receiving this because you are subscribed to this thread.Message ID: @.***>