search

nkkollaw / zubr

Wrapper library to fix inconsistencies in PHP's core functions
MIT License
99 stars 6 forks source link

Zubr isn't bundled with PHP #116

Open nkkollaw opened 7 years ago

nkkollaw commented 7 years ago

I don't know if GitHub offers a better tool for random discussions, but I thought I'd open a random thread so that we can talk about whatever at hand unless we actually do end up using Slack.

nkkollaw commented 7 years ago

@ddziaduch : would it make any sense if I added functions, and you helped me out building tests?

They're not my forte (just yet) :-/

We have many functions to cover, and while your work has been awesome, we have to find some way to speed it up or we'll never reach version 1.0 (there are potentially 1000s of functions).

I will start thinking about writing a tool that let us sort out functions that are already OK with functions that need checking.

Also, should I try to recruit more people on Reddit?

ddziaduch commented 7 years ago

Sure thing, I can do tests

nkkollaw commented 7 years ago

I looked at it last night.

There's this project called Locutus that has already built tests for their project: https://github.com/kvz/locutus, tests are here: https://github.com/kvz/locutus/tree/master/test/languages/php

I want to create a tool to extract and convert their tests to PHP so that we don't have to build them from scratch, but merely check them

I'll start working on this tool ASAP—even tomorrow.

In the meantime I would suggest we don't add any code. I'll also create some issues to keep track of all this and to explain better.

Have faith!!! :-)

nkkollaw commented 7 years ago

...I used Zubr today for the first time.

I must say that it's pretty awesome.