search

nklbdev / godot-4-importality

Universal raster graphics and animations importers pack
MIT License
337 stars 7 forks source link

Use `EditorSettings` instead of `ProjectSettings`. #19

Closed rylydou closed 10 months ago

rylydou commented 11 months ago

Most of settings for this addon seam to be only for the paths to executables. Using Editor Settings instead of Project Settings would work better for teams who use different operating systems.

I think it should be as simple as replacing every instance of ProjectSettings with EditorSettings in project_setting.gd.

rylydou commented 11 months ago

I will try this change in my project and let you know if there are any problems.

nklbdev commented 11 months ago

Thanks, that's a good point. I will also try to transfer the Importality settings to the editor settings.

I'm really sorry, but I couldn't devote time to this project this week because I'm very busy at work. I'll try the next one.

nklbdev commented 11 months ago

I tried moving the plugin settings from ProjectSettings to EditorSettings. I think I succeeded, although there were some minor pitfalls.

Please test the latest version of the use_editor_settings_instead_of_project_settings branch on your project.