nklbdev / godot-4-importality

Universal raster graphics and animations importers pack
MIT License
337 stars 7 forks source link

Pixelorama imported as SpriteFrames results in empty frames #27

Closed ChiliEater closed 2 months ago

ChiliEater commented 5 months ago

On the latest master branch of Godot the add-on currently works without errors. However, when I try to import a .pxo file as SpriteFrames it generates the object without the actual sprites:

image

Do you know if this is a regression your end? Any help is appreciated. If you want, I can also provide the .pxo file.

nklbdev commented 5 months ago

Hello! I also had this problem. I was very surprised. One of the latest Godot updates may have broken backwards compatibility.

But there is good news: in the latest DEV versions, the resource PortableCompressedTexture[2|3]D has been corrected. Therefore, we can use it from plugin code instead of saving a separated PNG file. This is how I did it in the file atlas_maker.gd.

Try to take the plugin version from the fix_empty_frames branch and tell me about the results.

The PNG images that the plugin creates next to the imported file are no longer needed. If they remain, you can try to remove them. This shouldn't affect anything. Now the texture in compressed form is saved directly inside the SpriteFrames resource.

ChiliEater commented 2 months ago

Sorry for the late reply. The fixes from the branch have been working fine for me. Thank you!