nkoehler / mat-video

:tv: mat-video is an Angular 8/9+ video player using Material!
https://nkoehler.github.io/mat-video/
MIT License
91 stars 47 forks source link

Exposing the current time directly from the player #22

Closed thibserot closed 5 years ago

thibserot commented 5 years ago

PLEASE FILL THIS OUT IF YOU CONTRIBUTE!

What kind of change does this PR introduce? (check one with "x")

What is the current behavior? (You can also link to an open issue here)

To access the currentTime you need to subscribe yourself to the video.timeupdate event and to update the current time from an external source you need to handle it manually as well

What is the new behavior?

The contribution creates a ngModel like binding called time which you can read to get the current time in seconds or write to, to update the player current time

Does this PR introduce a breaking change? (check one with "x")

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

N/A

Other information:

N/A

nkoehler commented 5 years ago

I tslinted the code, but other than that it seems to be okay.

These changes will be available in the next release. Thank you for the contribution.

thibserot commented 5 years ago

Thank you for integrating the PR so quickly!