nkoehler / mat-video

:tv: mat-video is an Angular 8/9+ video player using Material!
https://nkoehler.github.io/mat-video/
MIT License
91 stars 47 forks source link

Please do not hardcode the URL to the material icons webfont #30

Open yoe opened 5 years ago

yoe commented 5 years ago

Hi,

I'm trying to build an angular video-playing application that, for reasons of privacy, does not access any external resources. My application has the "material-design-icons-iconfont" npm package, but unfortunately your mat-video package hardcodes the URL to the material design icons webfont on google's servers, which breaks my application.

Since the default setup for angular material is to already include a link to those webfonts into a CSS stylesheet in index.html, this seems like duplication of effort, and it breaks my (valid, IMHO) use case in that I would have to fork your component in order to do what I want.

Would it be possible to declare that the "Material Icons" webfont will be used and that it is necessary to include it, very much like is being done with the Roboto font right now? That way I can just serve them locally and include things that way if I so choose.

nkoehler commented 4 years ago

Will investigate this