search

nkolban / esp32-snippets

Sample ESP32 snippets and code fragments
https://leanpub.com/kolban-ESP32
Apache License 2.0
2.36k stars 710 forks source link

Problem with identifying notification source #743

Open a0di opened 5 years ago

a0di commented 5 years ago

Hey! I've been checking new multiconnect features (BLE client) and came across a problem with identifying the remote device from which we recieved the notification. This is especially critical when we have peer devices with identical services. Maybe I've missed something? I suggest adding gatt_if or remote device address to the callback: (notify_callback)(BLERemoteCharacteristic pBLERemoteCharacteristic, uint8_t* pData, size_t length, bool isNotify, esp_gatt_if_t gatt_if)

chegewara commented 5 years ago

Hi @elCaporal yes, its something that can be considered as good change especially with multiconnect. Thanks.