search

nkotaa / pe

0 stars 0 forks source link

Specifying a new course name has no effect #4

Open nkotaa opened 2 months ago

nkotaa commented 2 months ago

Steps to reproduce

  1. Run add course ORIGINAL_DOES_NOT_EXIST y/1 t/1
  2. On the prompt to provide course name, type: NEW_DOES_NOT_EXIST

Expected

Either NEW_DOES_NOT_EXIST to be added to schedule or warning that initial and specified course names differ.

Actual

Sure! ORIGINAL_DOES_NOT_EXIST has been added to your schedule.

Extra information

It seems the course name saved is a concatenation of both inputs. This is confirmed with the view y/1 t/1 command which produces

Year 1 Semester 1:
  ORIGINAL_DOES_NOT_EXIST NEW_DOES_NOT_EXIST (MC: 4)
Term MCs: 4
soc-se-bot commented 2 months ago

Team's Response

With the steps given by the tester, our app will take "ORIGINAL_DOES_NOT_EXIST" as the course code and "NEW_DOES_NOT_EXIST" as the course name. When viewing the timetable, it shows both course code and course name. They are two separate entities. Tester has misunderstood the command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Say I run add course ORIGINAL_DOES_NOT_EXIST y/1 t/1. This is what the application responds with:

2024-04-23T22:59:01,877737395+08:00.png

The UG neither explains this behaviour of add nor defines what course name means (in the glossary or otherwise). Thus it is reasonable for me to take course name to mean course code + description in full. In other words, the application is asking me to restate the course to add.

If I then type NEW_DOES_NOT_EXIST (either by accident or because I changed my mind on the course to add), I would expect either

  1. NEW_DOES_NOT_EXIST to be added (because the application allows users to change input mid-command); otherwise
  2. An error stating initial and restated course names differ.

Instead the application outputs

2024-04-23T23:59:25,543711768+08:00.png

making me believe my input was ignored or something has gone wrong.

I believe this is a strong case of FunctionalityBug with behaviour differing from normal expectations.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Reported behaviour is encountered whenever a not-in-database course is added. A quick test reveals the application does not contain many GE mods, taken by Engineering students. Thus it is likely for stated bug to cause "occasional inconvenience to some users" (`severity.Medium`).