search

nkowaokwu / igbo_api

An API exposing Igbo words, definitions, and more
https://igboapi.com
Apache License 2.0
315 stars 138 forks source link

Unable to pass tests on newly cloned fork #656

Open itsjayway opened 1 year ago

itsjayway commented 1 year ago

Describe the bug yarn jest does not pass on master branch when newly cloned

To Reproduce Steps to reproduce the behavior: 1) Fork 2) git clone git@github.com:jibranabsarulislam/igbo_api.git igbo_api_test 3) cd igbo_api_test 4) yarn install 5) yarn build 6) firebase content: a. console.firebase.google.com -> Create a project b. project name: igboapitest project id (is also): igbopitest c. no analytics -> Create project d. change .firebaserc default and staging to igboapitest e. "Get started by adding Firebase to your app" -> Web f. app nickname: igbotestapp g. copy config into src/services/firebase.js (into both staging and prod config) h. firebase login i. firebase use default 7) yarn dev # navigating to http://127.0.0.1:8080/ renders page 8) ctrl+C to stop development server 9) yarn start:database # terminal 1 10) yarn jest # terminal 2 a. Database is connected b. Seeding database... c. tests start, and fails 3 suites/56 tests

Expected behavior Codebase on master branch should pass established tests

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Screenshots (if applicable) https://github.com/nkowaokwu/igbo_api/pull/653#issuecomment-1592521846 image

image

ijemmao commented 1 year ago

@jibranabsarulislam can you copy and paste the entire error message when you get a chance?

itsjayway commented 1 year ago

@ijemmao https://gist.github.com/jibranabsarulislam/f1efbf83d0bf6343d037529ab3a9a812

ijemmao commented 1 year ago

thanks for the link, i'll take a look thru the logs @jibranabsarulislam

i merged a fix so that future PRs will be able to have their tests run automatically within our CI so you don't need to run tests on your local machine in the future - however, this doesn't fix the root issue that's happening since we encourage writing new tests for new features, I'll keep this issue open!