nkowaokwu / igbo_api

An API exposing Igbo words, definitions, and more
https://igboapi.com
Apache License 2.0
316 stars 141 forks source link

Scrape 1000 Most Common Igbo Words #66

Closed ijemmao closed 4 years ago

ijemmao commented 4 years ago

Scrape the data that's found in this site and append it to the JSON dictionary objects.

https://1000mostcommonwords.com/1000-most-common-igbo-words/

If the word doesn't exist in the JSON dictionary, create a new object where that object has definitions, word, wordClass, phrases, examples, and variations.

If the word already exists in the JSON dictionary, append that information.

pappyJ commented 4 years ago

Screenshot from 2020-10-09 14-24-14

I Scrapped D Data Using My Little Experiernce... Does The Data Need Additional fields ???...

ijemmao commented 4 years ago

@pappyJ wowow this is awesome! Yeah, what you want to do is that you want to include the logic that you wrote that managed to create this words.json object and incorporate it into the main codebase.

The script that you wrote could probably live in the dictionaries directory, and then you can name the JSON file that you've created as ig-en-1000-common.json.

Also, could you change the meaning key to definition so that it follows the current data structure as close as possible?

pappyJ commented 4 years ago

Thanks ma'am .. I'll it give my best shot

ijemmao commented 4 years ago

Let me know if you have more questions!

pappyJ commented 4 years ago

Sure

On Fri, Oct 9, 2020, 11:59 PM Ijemma Onwuzulike notifications@github.com wrote:

Let me know if you have more questions!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ijemmao/igbo_api/issues/66#issuecomment-706436121, or unsubscribe https://github.com/notifications/unsubscribe-auth/APW5Z4AZHANLF7TDYFAFBQDSJ6IW7ANCNFSM4SFF33PQ .

pappyJ commented 4 years ago

Screenshot from 2020-10-10 08-22-53 How About this Structure???

pappyJ commented 4 years ago

Screenshot from 2020-10-10 08-34-06

Made Some Changes to fit d base dictionary pattern .. Check for any required changes so i make some code refactor and create a PR

ijemmao commented 4 years ago

@pappyJ This looks perfect.

All I would say is to make sure that you include both the script that was able to create this json file and the json file itself in the main project codebase so that in a future ticket, we can try to merge ig-en-1000-common.json with our ig-en.json and ig-en_expanded.json dictionaries.

pappyJ commented 4 years ago

OKk

ijemmao commented 4 years ago

Closed by #133