Spell loader calls GoogleCloudStorage in unit testing

[nkprasad12]

The server test calls registerChatRoutes during unit testing, which means that spellLoader.load(https://github.com/nkprasad12/dnd/blob/eee378b611a68e4d2c30e1f4548b1264c56d9663/src/server/chat/chat_socket.ts#L28) is called during testing, which by default tries to call Google Cloud Storage.

There are two possibilities here:

• Band aid: As the SheetLoader does, we can move it to only load data after someone has connected to the socket: https://github.com/nkprasad12/dnd/blob/eee378b611a68e4d2c30e1f4548b1264c56d9663/src/server/chat/chat_socket.ts#L52
• Ideal solution: We have a fake that swaps in for GoogleCloudStorage in other tests. The best solution would be that this fake is automatically used for all unit tests, along with mock-fs
  • The fake: https://github.com/nkprasad12/dnd/blob/eee378b611a68e4d2c30e1f4548b1264c56d9663/src/server/storage/fake_backup_storage.ts#L8
  • mock-fs example: https://github.com/nkprasad12/dnd/blob/efb4a3b8ed34f358c6f784fca007ac51f7bdba35/src/server/storage/storage_util.test.ts#L2