Closed nkprince007 closed 6 years ago
Can we rather have an editorconfig?
I don't think we need it. Because go fmt
is enough to do the stuff. I just added something so that Emacs users(if any and including me) could get the tab width of 4 spaces when opening a file in this project.
:P what about people using other text editors? EditorConfig unifies all of the needs.
also, I think we should rather take care of conditional builds rather than having two functions. Can you cherry pick and squash the commits together?
I don't know how editorconfig will perform with Emacs because different languages, modes and buffers use different variables to set styling properties. Its better if we can try it out.
Please rebase your branch with master so that this PR can be merged. Also check for failing CI builds.
Is the PR okay now?