pairedEndowmentIndex is never used and if... endowment in pairedEndowments will never run because parentEndowments and pairedEndowments are mutually disjoint.
The pairedEndowments loop uses index, which is the same as it was on the last iteration of the parentEndowments loop, which correlates traits that should not be correlated.
Three separate hashes are created for pairedEndowments, but only one is needed because they all use the same value.
Updated behavior:
Only one hash is created for pairedEndowments
All pairedEndowments use the same value, which is now independent of the last iteration of the parentEndowments loop
nkremerh
commented
7 months ago
Current repo behavior:
pairedEndowmentIndexis never used andif... endowment in pairedEndowmentswill never run becauseparentEndowmentsandpairedEndowmentsare mutually disjoint.pairedEndowmentsloop usesindex, which is the same as it was on the last iteration of theparentEndowmentsloop, which correlates traits that should not be correlated.pairedEndowments, but only one is needed because they all use the same value.Updated behavior:
pairedEndowmentspairedEndowmentsuse the same value, which is now independent of the last iteration of theparentEndowmentsloop