nkremerh / sugarscape

Development repository for the Digital Terraria Lab implementation of the Sugarscape agent-based societal simulation.
https://github.com/digital-terraria-lab/sugarscape
MIT License
7 stars 11 forks source link

Modifies example configs' movement to 1000 to match range distribution in book #69

Closed colinhanrahan closed 2 months ago

colinhanrahan commented 2 months ago

Current repo:

Changes:

nkremerh commented 2 months ago

Sorry to do this to you, but do this the other way around. Our implementation of Sugarscape adds new functionality by splitting vision and movement. We shouldn't handicap our features out-of-the-box to what the book has. Instead, we should adjust our examples to match the more limited scope of the book.

nkremerh commented 2 months ago

Also set it to 1000 rather than 9999. The latter case could be misinterpreted as our logical max in the code being 9999 rather than the max size of an integer in the system. They're both equally comic in size.

colinhanrahan commented 2 months ago

@nkremerh Done. Where should we add the note about why we're using a comically large value (if we are adding a note)? Adding it to every single example might be a bit much.

nkremerh commented 2 months ago

No need for additional comment. At most, we may put a note in the wiki or a second README inside the examples directory. A second README sounds more appealing since it's self-contained in the repo on download, but we don't need that right now.