Closed amuller26 closed 2 months ago
Good work!
@colinhanrahan please test for correctness.
I will tidy up some debug message wording then merge once I get the green light.
Numerical correctness looks good, but I'll do a little more testing.
If we're committing to proper config verification—and this would be a separate feature—there are plenty of other config settings that cannot take negative values. We should either disclose this in the README or verify them beforehand, or both.
@amuller26 Ready to merge?
@nkremerh yes.
Numerical correctness looks good, but I'll do a little more testing.
If we're committing to proper config verification—and this would be a separate feature—there are plenty of other config settings that cannot take negative values. We should either disclose this in the README or verify them beforehand, or both.
New item: would you like to add this more thorough checking?
@nkremerh I created the Kanban card.
I was not sure if I should have added the debugMode statements to the selfishnessFactor and tribalFactor.