Adds sort to every config option that represents a range of values

[amuller26]

• Modified/simplified check for agentMaxAge
• Added agentSelfishnessFactor verification to check if it is disabled with debugMode statement.
• Modified logic of agentDecisionModelTribalFactor to check if it is disabled with debugMode statement.
• Added a check to make sure the number of unique ethical decision models is less than or equal to the total number of colors in the GUI.

I was not sure if I should have added the debugMode statements to the selfishnessFactor and tribalFactor.

[nkremerh]

Good work!

@colinhanrahan please test for correctness.

I will tidy up some debug message wording then merge once I get the green light.

[colinhanrahan]

Numerical correctness looks good, but I'll do a little more testing.

If we're committing to proper config verification—and this would be a separate feature—there are plenty of other config settings that cannot take negative values. We should either disclose this in the README or verify them beforehand, or both.

[nkremerh]

@amuller26 Ready to merge?

[amuller26]

@nkremerh yes.

[nkremerh]

Numerical correctness looks good, but I'll do a little more testing.

If we're committing to proper config verification—and this would be a separate feature—there are plenty of other config settings that cannot take negative values. We should either disclose this in the README or verify them beforehand, or both.

New item: would you like to add this more thorough checking?

[amuller26]

@nkremerh I created the Kanban card.