nksaraf / vinxi

The Full Stack JavaScript SDK
https://vinxi.vercel.app
MIT License
1.33k stars 56 forks source link

Docs: SSR docs lacking example #237

Open redbar0n opened 4 months ago

redbar0n commented 4 months ago

The docs page:

https://vinxi.vercel.app/guide/add-to-existing-vite-app.html

Says:

Vinxi gives you the ability to add server-side functionality (SSR) to an existing Vite app.

But the following example on the page does not show how to add SSR to an existing Vite app.

Maybe some of the TanStack Router examples could be used?

https://tanstack.com/router/latest/docs/framework/react/examples/vinxi-basic-ssr

https://tanstack.com/router/latest/docs/framework/react/examples/vinxi-basic-ssr-streaming

But maybe it would be better to show a simpler example that doesn't even have a client-side router (like TanStack Router), just SSR.

Maybe this part from the "building a metaframework with Vinxi" article could be used?

https://www.brenelz.com/posts/building-a-react-metaframework-with-vinxi/#react-ssr

nksaraf commented 4 months ago

Yeah I think its a good idea. Im trying to get the docs to get a good level. Any help would be appreciated. If you feel like you can help with this ,would love that