nksaraf / vinxi

The Full Stack JavaScript SDK
https://vinxi.vercel.app
MIT License
1.33k stars 56 forks source link

fix: allow serving resource files from monorepo in dev server #261

Closed yume-chan closed 3 months ago

yume-chan commented 3 months ago

My project loads SVG files from another package in a monorepo, but it doesn't work in vinxi-based Solid Start.

vinxi modified server.fs.allow value in Vite config, but it doesn't follow the documentation to use searchForWorkspaceRoot method to properly allow monorepo usage: https://vitejs.dev/config/server-options.html#server-fs-allow

codesandbox[bot] commented 3 months ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: e6f9faf4ac5bcc79edcf3e47fa3448caa28f92ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages | Name | Type | | ------------------------------------- | ----- | | vinxi | Patch | | @vinxi/router | Patch | | example-react-server | Patch | | react-rsc-spa | Patch | | react-rsc-ssr | Patch | | example-react-spa-basic | Patch | | react-spa-mdx | Patch | | react-spa-tanstack-router-app | Patch | | example-react-spa-tanstack-router-app | Patch | | react-ssr-basic-cloudflare | Patch | | react-ssr-basic | Patch | | react-ssr-tanstack-router-app | Patch | | react-ssr-wouter | Patch | | solid-spa-basic | Patch | | solid-ssr-basic | Patch | | example-ssr-solid-router | Patch | | example-vanilla-empty | Patch | | example-vanilla-partyroom | Patch | | example-vanilla-server | Patch | | example-vanilla-spa | Patch | | example-vanilla-stack | Patch | | example-vanilla-trpc | Patch | | test-multi-spa | Patch | | test-react-rsc | Patch | | test-react-srv-fn | Patch | | react-ssr-test-fs | Patch | | test-react-to-web-request | Patch | | test-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @nksaraf on Vercel.

@nksaraf first needs to authorize it.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 7:47am