search

nksaraf / vinxi

The Full Stack JavaScript SDK
https://vinxi.vercel.app
MIT License
1.33k stars 56 forks source link

chore(vinxi): ensure installing vinxi only install one esbuild version #271

Closed ludofischer closed 2 months ago

ludofischer commented 3 months ago

Align direct esbuild dependency version with transitive esbuild dependency from vite and nitropack.

When creating a solid-start app, both esbuild 0.18 and esbuild 0.20 are installed. This happens because the vite dependency in vinxi allows Vite 5.2.x which pulls in esbuild 0.20, but vinxi depends on esbuild 0.18.

Since vinxi uses esbuild directly just to process its own config, I thought it should be safe to update to esbuild 0.20, saving some download time and perplexity. I've also updated the Vite version range to make the result more consistent between installs with and without an existing package lock file.

Esbuild release notes: https://github.com/evanw/esbuild/releases

codesandbox[bot] commented 3 months ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

vercel[bot] commented 3 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @nksaraf on Vercel.

@nksaraf first needs to authorize it.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 49fefb83ed2cb1ca365a4ab1d091710b832df475

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages | Name | Type | | ------------------------------------- | ----- | | vinxi | Patch | | @vinxi/router | Patch | | example-react-server | Patch | | react-rsc-spa | Patch | | react-rsc-ssr | Patch | | example-react-spa-basic | Patch | | react-spa-mdx | Patch | | react-spa-tanstack-router-app | Patch | | example-react-spa-tanstack-router-app | Patch | | react-ssr-basic-cloudflare | Patch | | react-ssr-basic | Patch | | react-ssr-tanstack-router-app | Patch | | react-ssr-wouter | Patch | | solid-spa-basic | Patch | | solid-ssr-basic | Patch | | example-ssr-solid-router | Patch | | example-vanilla-empty | Patch | | example-vanilla-partyroom | Patch | | example-vanilla-server | Patch | | example-vanilla-spa | Patch | | example-vanilla-stack | Patch | | example-vanilla-trpc | Patch | | test-multi-spa | Patch | | test-react-rsc | Patch | | test-react-srv-fn | Patch | | react-ssr-test-fs | Patch | | test-react-to-web-request | Patch | | test-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR