search

nksaraf / vinxi

The Full Stack JavaScript SDK
https://vinxi.vercel.app
MIT License
1.33k stars 57 forks source link

Change host to string for start command, to be able to set host #279

Open bondehagen opened 2 months ago

codesandbox[bot] commented 2 months ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

vercel[bot] commented 2 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @nksaraf on Vercel.

@nksaraf first needs to authorize it.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 0208a903565ba06d09cca2c99310978df698e2cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages | Name | Type | | ------------------------------------- | ----- | | vinxi | Patch | | @vinxi/router | Patch | | example-react-server | Patch | | react-rsc-spa | Patch | | react-rsc-ssr | Patch | | example-react-spa-basic | Patch | | react-spa-mdx | Patch | | react-spa-tanstack-router-app | Patch | | example-react-spa-tanstack-router-app | Patch | | react-ssr-basic-cloudflare | Patch | | react-ssr-basic | Patch | | react-ssr-tanstack-router-app | Patch | | react-ssr-wouter | Patch | | solid-spa-basic | Patch | | solid-ssr-basic | Patch | | example-ssr-solid-router | Patch | | example-vanilla-empty | Patch | | example-vanilla-partyroom | Patch | | example-vanilla-server | Patch | | example-vanilla-spa | Patch | | example-vanilla-stack | Patch | | example-vanilla-trpc | Patch | | test-multi-spa | Patch | | test-react-rsc | Patch | | test-react-srv-fn | Patch | | react-ssr-test-fs | Patch | | test-react-to-web-request | Patch | | test-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

birkskyum commented 2 months ago

This could be useful for dev as well. Seems like it's always localhost

nksaraf commented 2 months ago

can we pass host without any value and it gets exposed on the public API, thats the default nitro API and that works well. It should then be able to add a proper host to it.

bondehagen commented 1 month ago

can we pass host without any value and it gets exposed on the public API, thats the default nitro API and that works well. It should then be able to add a proper host to it.

Not sure I follow. I'm only fixing a typo, host is not a boolean, but a string for the start coomand. My use case is to be able to bind to both ipv4 and ipv6 at the same time with [::].

bondehagen commented 1 month ago

@nksaraf Can you merge this now?