nksaraf / vinxi

The Full Stack JavaScript SDK
https://vinxi.vercel.app
MIT License
1.33k stars 57 forks source link

Fixed node imports incompatibility #286

Closed Akkuma closed 2 weeks ago

Akkuma commented 2 months ago

Node has reserved # for imports

Entries in the "imports" field must always start with # to ensure they are disambiguated from external package specifiers.

This swaps it to $. I tested it by modifying my node_modules install of vinxi and my dev server worked again resolving #249.

codesandbox[bot] commented 2 months ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 15c62e1103fd496135dbb59768d2ba9b6e70acc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages | Name | Type | | ------------------------------------- | ----- | | @vinxi/react-server | Patch | | vinxi | Patch | | example-react-server | Patch | | @vinxi/router | Patch | | react-rsc-spa | Patch | | react-rsc-ssr | Patch | | example-react-spa-basic | Patch | | react-spa-mdx | Patch | | react-spa-tanstack-router-app | Patch | | example-react-spa-tanstack-router-app | Patch | | react-ssr-basic-cloudflare | Patch | | react-ssr-basic | Patch | | react-ssr-tanstack-router-app | Patch | | react-ssr-wouter | Patch | | solid-spa-basic | Patch | | solid-ssr-basic | Patch | | example-ssr-solid-router | Patch | | example-vanilla-empty | Patch | | example-vanilla-partyroom | Patch | | example-vanilla-server | Patch | | example-vanilla-spa | Patch | | example-vanilla-stack | Patch | | example-vanilla-trpc | Patch | | test-multi-spa | Patch | | test-react-rsc | Patch | | test-react-srv-fn | Patch | | react-ssr-test-fs | Patch | | test-react-to-web-request | Patch | | test-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

@Akkuma is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

XiNiHa commented 1 month ago

@nksaraf Can we have this reviewed and merged? Utilizing package.json#imports is one of the best ways to use different kinds of modules per condition and Vinxi not supporting it is impacting our adaption of Vinxi/SolidStart.