nksaraf / vinxi

The Full Stack JavaScript SDK
https://vinxi.vercel.app
MIT License
1.33k stars 57 forks source link

Fix style collection to not collect from dynamic deps #310

Closed XiNiHa closed 2 weeks ago

XiNiHa commented 3 weeks ago

This makes Vinxi stop collecting styles from dynamic dependencies, which triggers Vite transforms per each dependency and drops dev performance significantly if done on modules that contain a lot of dynamic dependencies, potentially because of using import.meta.glob().

codesandbox[bot] commented 3 weeks ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 3d79eb65e9c312ecb20d9cd504c88aabcb7d84bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 weeks ago

@XiNiHa is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.