Closed katywings closed 2 months ago
Latest commit: 5f825cc2dd6bc1b2a5fbd67c8a634d04857dfbc2
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@katywings is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.
A member of the Team first needs to authorize it.
Open the branch in Web Editor • VS Code • Insiders
Open Preview
This PR tries to reduce the flakiness of the tests as much as possible. But it isn't perfect: sometimes the page hydration just fails for unknown reasons, especially on Windows. The new
isReady
check tries to recover from hydration fails, by reloading the page, which seems to work pretty solidly. Longterm though we should think about rewriting a lot of the tests, especially those related to HMR &fixture.updateFile
.I ran the updated tests countless times with force-pushes and so far got zero fails with the latest version.