nksaraf / vinxi

The Full Stack JavaScript SDK
https://vinxi.vercel.app
MIT License
2.19k stars 80 forks source link

Exit status 0 when prererendering fails #362

Open oscartbeaumont opened 2 months ago

oscartbeaumont commented 2 months ago

I am running vinxi build on a Solid Start app and I have a bug in my code where I access window.

The bug itself is fine, however I noticed that the Vinxi process returns the 0 exit code which should only be used to indicate success.

If I run pnpm build && echo $? I see 0 where I would expected a non-zero exit code.

This matters because it's common for CI processes to use the status to determine if it should continue executing.