Open nikitavoloboev opened 1 month ago
Open the branch in Web Editor • VS Code • Insiders
Open Preview
Latest commit: 1773fd79a575083bcfdd2b2c16aefca873bde035
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
vinxi-website | ❌ Failed (Inspect) | Oct 3, 2024 6:48pm |
I was about to merge this but realized that you removed the resolveCertificate code. To be honest I'm not sure how it got there and if it is necessary but it suggests this PR is changing more than just exposing the hostname.
Is that intentional?
FWIW, HTTPS with custom hostnames works in my own project. Uh, assuming here that custom hostname is just a modified /etc/hosts
. Works for me with both dev and prod builds+serves, though I'm using wrangler pages dev dist/ --https-cert-path ./.cert/cert.pem --https-key-path ./.cert/key.pem
for the "prod" serve.
In your code, you use devServer
with host
and https
options, which aren't documented. Can you import the key/cert like I did and see if it works for you?
for reference, I am using it here: https://github.com/nikitavoloboev/new-telegram-app