nkt / atom-autocomplete-modules

Autocomplete for require/import statements
https://atom.io/packages/autocomplete-modules
MIT License
114 stars 35 forks source link

Bugfix/global not working #117

Closed jonyeezs closed 5 years ago

jonyeezs commented 5 years ago

This may not resolve #115 but it'll definitely handle areas where exceptions were thrown that could be handled more gracefully.

Anytime where a lookup fails, it will console.error log it and return no results.

This should allow other relevant lookups to continue.

This is to note that perhaps those lookup failures were user configuration issues or failed initialisation.

As well, piggy-backing on this PR is a fix (work-around) to some changes that i wasn't looking out for in esm-export, as i'm not a :100: on the lib (PSA: never use a library you have no idea how it works).

Well i do know what it does so that should be good enough to be use. Just need to have a dive in it (missing docs) - TODO!