Closed cpojer closed 1 month ago
Super excited you're open sourcing so much of the game! Could I pick this issue up?
Yes, please give it a try! Feel free to ping me on the #tech channel on Discord if you have questions.
@cpojer Got a basic version working, but wanted to clarify how some of the MapObject
properties should be handled, specifically:
id
- should this be auto-generated or just left as an empty string? From what I've read so far, I think an empty string would sufficeslug
- same as id
campaigns
- I'm assuming this should be empty (e.g. campaigns: { edges: [] }
creator
- I'm assuming we can use the placeholder viewer
valuesThanks!
For slug
, please call toSlug
on the map name.
The other suggestions sound good to me.
I bumped up the funding to $50 since you are the first contributor.
Thank you! Just excited to learn more about the codebase and making games with web tech, but that's super nice!
I set my PR as ready for review for when you're free to take a first pass. Obviously still getting used to the codebase, so let me know what feedback you have! Also let me know if you'd like me to include tests. Definitely can to be thorough and include them but I also feel like it's not as necessary compared to something that updates the map editor, core unit logic, etc.
Thanks for contributing, $50 were sent to you!
Thanks! Appreciate the review and for open sourcing this 🎉
For the Open Source website, it would be great if the Map Editor Playground supported "saving" and loading maps. Let's store a map in the URL. When loading the playground, the URL can be decoded to load a map.
Steps
map-editor.tsx
.mapObject
to theMapEditor
component.MapObject
.*Note: The Map Editor might not re-render with new state if the
mapObject
that gets passed in changes. It may be necessary to set thekey
prop to wipe away map editor state.Links
Funding