build: enable consistent type imports rule

[ad1992]

Enabled the consistent-type-imports so its clear from imports whether type is being imported.

I have auto fixed the codebase, however I am happy to revert if that is unnecessary and change the rule to throw warning instead.

cc @cpojer

[cpojer]

Thanks for the contribution! I looked at this rule previously but chose not to enable it. Here is what I landed on before:

• Importing a JavaScript object only by type, and then using that object in the same file requires removing the type from import which seems inconvenient. There is an autofix, but it still makes things slower or requires me to stop and go back.
• I don't really make a difference whether I only import a type or not as almost all downsides from importing the real thing are mitigated in this codebase. There are no side effects in the code base, all code is more-or-less required anyway, and rollup+esbuild are strong at removing unused imports.
• One import statement should be for one file. Having possibly two for each doesn't seem easy to browse (This can be changed via the plugin's settings, I assume?).

So in the end, what is the upside? Is it only a minor change in how modules are bundled, or is there something big I'm missing that makes this behavior better than the current situation?

[cpojer]

I asked on Twitter: https://x.com/cpojer/status/1794462636219801852

Then a GitHub issue was surfaced in which a TS team member said:

The intention is for you not to use import type unless you need to.

Let's not move forward with this.

[ad1992]

Hi @cpojer sorry I was busy so couldn't back on this one. This is just a user preference and has nothing to do with bundling as the typings will be removed irrsepective of how its imported. Hence I agree with your reasonings and since its not needed in the codebase so better to close it.