perf: draw portrait with canvas

nkzw-tech / athena-crisis

Athena Crisis is an Advance Wars inspired modern-retro turn-based tactical strategy game. Athena Crisis is open core technology.

https://athenacrisis.com/open-source

Other

1.37k stars 105 forks source link

perf: draw portrait with canvas #32

Closed puroong closed 1 month ago

puroong commented 1 month ago

Description

Resolves #14

store all portrait images in imageMap
- this is necessary in order to load images with spriteImage
draw portrait with canvas
animate portrait with setInterval

Memory Usage

1000 Portraits

with img tag (as is)

with canvas

cpojer commented 1 month ago

@puroong wow, thanks for the contribution! This is very nice, and will make Athena Crisis work much better on low-end devices. I left a few comments to make sure we are cleaning things up.

puroong commented 1 month ago

@cpojer Thanks for the opportunity! I addressed the feedbacks and its ready for review 😄

puroong commented 1 month ago

My bad... I should have run the tests in local.. fixed lint errors in this commit!

style: lint

cpojer commented 1 month ago

Thank you for your contribution. The funds were distributed to you.