feat: ♿ added aria-hidden="true" to svg icons for better accessibility purposes

nl-design-system / utrecht

Work in Progress: Utrecht Design System based on the NL Design System architecture. Storybook: https://nl-design-system.github.io/utrecht/storybook/

https://nl-design-system.github.io/utrecht/

European Union Public License 1.2

23 stars 15 forks source link

feat: ♿ added aria-hidden="true" to svg icons for better accessibility purposes #2282

Open MeesoPost opened 3 months ago

MeesoPost commented 3 months ago

add aria-hidden="true" to Utrecht SVG icon set ♿️

[x] The element is hidden from the accessibility API.

I added the attribute to all the SVG icons by adding it to the svgo.config.mjs file so all SVG icons are affected with the change with the added change i tested it in the Utrecht storybook and the icon is hidden/ignored, but still visible on the page

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
utrecht	❌ Failed (Inspect)			Oct 7, 2024 4:46pm

Robbert commented 3 months ago

@MeesoPost Zou je ook de icon component willen controleren in alle framework storybooks? Bijvoorbeeld: misschien moet aria-hidden ook nog toegevoegd worden aan de <utrecht-icon> web component en de <Icon/> React component.