Closed nahls closed 4 years ago
Merging #17 into master will increase coverage by 1.37%. The diff coverage is 62.50%.
1.37%
62.50%
@@ Coverage Diff @@ ## master #17 +/- ## ========================================== + Coverage 63.10% 64.48% +1.37% ========================================== Files 5 5 Lines 103 107 +4 ========================================== + Hits 65 69 +4 Misses 38 38
47.36% <0.00%> (ø)
32.25% <50.00%> (+2.25%)
97.50% <100.00%> (+0.20%)
Continue to review full report at Codecov.
Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd7fd10...e3fdbfe. Read the comment docs.
Δ = absolute <relative> (impact)
ø = not affected
? = missing data
Looks fine. I did not see the changes related to avoiding duplication. I will merge this PR if you plan to do it in other PR.
Yes, I wanted to get this change out of the way before adding the checking before insert
Codecov Report
47.36% <0.00%> (ø)
32.25% <50.00%> (+2.25%)
97.50% <100.00%> (+0.20%)
Continue to review full report at Codecov.