search

nl2go / hetzner-invoice

Automatically download and transform Hetzner invoices.
MIT License
12 stars 1 forks source link

Create additional DB columns #17

Closed nahls closed 4 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #17 into master will increase coverage by 1.37%. The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   63.10%   64.48%   +1.37%     
==========================================
  Files           5        5              
  Lines         103      107       +4     
==========================================
+ Hits           65       69       +4     
  Misses         38       38
Impacted Files Coverage Δ
hetzner_invoice/invoice.py 47.36% <0.00%> (ø)
hetzner_invoice/scrape.py 32.25% <50.00%> (+2.25%) :arrow_up:
hetzner_invoice/combine.py 97.50% <100.00%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd7fd10...e3fdbfe. Read the comment docs.

sananguliyev commented 4 years ago

Looks fine. I did not see the changes related to avoiding duplication. I will merge this PR if you plan to do it in other PR.

nahls commented 4 years ago

Yes, I wanted to get this change out of the way before adding the checking before insert